From 3c69a95b9a84f629cb6e5215158f9332a731aae9 Mon Sep 17 00:00:00 2001 From: Zixun LI Date: Mon, 21 Oct 2024 17:04:51 +0200 Subject: [PATCH] dm: gpio: Return error when pull up/down is requested but set_flags ops is not implmentated Currently in _dm_gpio_set_flags() when set_flags ops is not implemented direction_output()/_input() is used, but pull up/down is not supported by these ops. Signed-off-by: Zixun LI --- drivers/gpio/gpio-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c index 0213271e3a6..da929c33447 100644 --- a/drivers/gpio/gpio-uclass.c +++ b/drivers/gpio/gpio-uclass.c @@ -705,6 +705,9 @@ static int _dm_gpio_set_flags(struct gpio_desc *desc, ulong flags) if (ops->set_flags) { ret = ops->set_flags(dev, desc->offset, flags); } else { + if (flags & GPIOD_MASK_PULL) + return -EINVAL; + if (flags & GPIOD_IS_OUT) { bool value = flags & GPIOD_IS_OUT_ACTIVE; -- 2.39.5