From 39a719dce59607d6abcac17cc2683aa9f2162539 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vincent=20Stehl=C3=A9?= Date: Mon, 7 Apr 2025 19:05:25 +0200 Subject: [PATCH] fwu: developerbox: fix dfu alt buffer clearing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The set_dfu_alt_info() function calls the ALLOC_CACHE_ALIGN_BUFFER() macro to declare a `buf' variable pointer into an array allocated on the stack. It then calls the memset() function to clear the useable portion of the array using the idiomatic expression `sizeof(buf)'. While this would indeed work fine for an array, in the present case we end up clearing only the size of a pointer. Fix this by specifying the explicit size `DFU_ALT_BUF_LEN' instead. Fixes: 6b403ca4dcf4 ("fwu: DeveloperBox: add support for FWU") Signed-off-by: Vincent Stehlé Cc: Masahisa Kojima Cc: Tom Rini Cc: Jassi Brar Reviewed-by: Mattijs Korpershoek Link: https://lore.kernel.org/r/20250407170529.893307-2-vincent.stehle@arm.com Signed-off-by: Mattijs Korpershoek --- board/socionext/developerbox/fwu_plat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/socionext/developerbox/fwu_plat.c b/board/socionext/developerbox/fwu_plat.c index 26031795b09..a8b111477ef 100644 --- a/board/socionext/developerbox/fwu_plat.c +++ b/board/socionext/developerbox/fwu_plat.c @@ -18,7 +18,7 @@ void set_dfu_alt_info(char *interface, char *devstr) struct mtd_info *mtd; int ret; - memset(buf, 0, sizeof(buf)); + memset(buf, 0, DFU_ALT_BUF_LEN); mtd_probe_devices(); -- 2.39.5