From 2b45ab3398a0ba119b1f672c7c56fd5a431b7f0a Mon Sep 17 00:00:00 2001 From: David Rientjes Date: Sun, 6 May 2007 14:50:00 -0700 Subject: [PATCH] oom: fix constraint deadlock Fixes a deadlock in the OOM killer for allocations that are not __GFP_HARDWALL. Before the OOM killer checks for the allocation constraint, it takes callback_mutex. constrained_alloc() iterates through each zone in the allocation zonelist and calls cpuset_zone_allowed_softwall() to determine whether an allocation for gfp_mask is possible. If a zone's node is not in the OOM-triggering task's mems_allowed, it is not exiting, and we did not fail on a __GFP_HARDWALL allocation, cpuset_zone_allowed_softwall() attempts to take callback_mutex to check the nearest exclusive ancestor of current's cpuset. This results in deadlock. We now take callback_mutex after iterating through the zonelist since we don't need it yet. Cc: Andi Kleen Cc: Nick Piggin Cc: Christoph Lameter Cc: Martin J. Bligh Signed-off-by: David Rientjes Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-format-patch failed