From 2865a8590f29c20a64cf0ba986f697d9973ed963 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Vincent=20Stehl=C3=A9?= Date: Tue, 6 May 2025 14:36:22 +0200 Subject: [PATCH] cmd: nvedit: fix efi env -e -i command help MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The help string for the `setenv -e' command shows a comma being used as the separator between address and size for the -i option, which deals with UEFI Variables contents passed as a buffer in memory. This is no longer the case since commit 2b3fbcb59f41 ("efi_loader: use ':' as separator for setenv -i") and commit 8f0ac536d493 ("efi: change 'env -e -i' usage syntax"), which changed the separator from a comma to a colon. Therefore fix this last bit of the help string accordingly. While at it, fix the comment of function do_env_set_efi(), which also mentions a comma as separator. Signed-off-by: Vincent Stehlé Cc: Tom Rini Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Cc: Maxim Uvarov Reviewed-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- cmd/nvedit.c | 2 +- cmd/nvedit_efi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/nvedit.c b/cmd/nvedit.c index 1f259801293..11c3cea882b 100644 --- a/cmd/nvedit.c +++ b/cmd/nvedit.c @@ -1263,7 +1263,7 @@ U_BOOT_CMD_COMPLETE( " \"-rt\": set runtime attribute\n" " \"-at\": set time-based authentication attribute\n" " \"-a\": append-write\n" - " \"-i addr,size\": use as variable's value\n" + " \"-i addr:size\": use as variable's value\n" " \"-v\": verbose message\n" " - delete UEFI variable 'name' if 'value' not specified\n" #endif diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index 32b7d049074..351ae47e870 100644 --- a/cmd/nvedit_efi.c +++ b/cmd/nvedit_efi.c @@ -367,7 +367,7 @@ out: * * This function is for "env set -e" or "setenv -e" command: * => env set -e [-guid guid][-nv][-bs][-rt][-at][-a][-v] - * [-i address,size] var, or + * [-i address:size] var, or * var [value ...] * Encode values specified and set given UEFI variable. * If no value is specified, delete the variable. -- 2.39.5