From 27b6c122512ca30399bb1b39cc42eda83901f304 Mon Sep 17 00:00:00 2001 From: Oscar Mateo Date: Mon, 16 Jun 2014 16:11:00 +0100 Subject: [PATCH] drm/i915/chv: Ack interrupts before handling them (CHV) Otherwise, we might receive a new interrupt before we have time to ack the first one, eventually missing it. Without an atomic XCHG operation with mmio space, this patch merely reduces the window in which we can miss an interrupt (especially when you consider how heavyweight the I915_READ/I915_WRITE operations are). Notice that, before clearing a port-sourced interrupt in the IIR, the corresponding interrupt source status in the PORT_HOTPLUG_STAT must be cleared. Spotted by Bob Beckett . v2: - Add warning to commit message and comments to the code as per Chris Wilson's request. - Imre Deak pointed out that the pipe underrun flag might not be signaled in IIR, so do not make valleyview_pipestat_irq_handler depend on it. v3: Improve the source code comment. Signed-off-by: Oscar Mateo Reviewed-by: Imre Deak Signed-off-by: Daniel Vetter --- Reading git-format-patch failed