bonding: fix two race conditions in bond_store_updelay/downdelay
authorNikolay Aleksandrov <nikolay@redhat.com>
Wed, 13 Nov 2013 16:07:46 +0000 (17:07 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Nov 2013 21:28:52 +0000 (16:28 -0500)
commitb869ccfab1e324507fa3596e3e1308444fb68227
treeeb35bfa07b83170abf65fbd88841d013b573e255
parent98e09386c0ef4dfd48af7ba60ff908f0d525cdee
bonding: fix two race conditions in bond_store_updelay/downdelay

This patch fixes two race conditions between bond_store_updelay/downdelay
and bond_store_miimon which could lead to division by zero as miimon can
be set to 0 while either updelay/downdelay are being set and thus miss the
zero check in the beginning, the zero div happens because updelay/downdelay
are stored as new_value / bond->params.miimon. Use rtnl to synchronize with
miimon setting.

CC: Jay Vosburgh <fubar@us.ibm.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Acked-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_sysfs.c