HID: multitouch: validate indexes details
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 11 Sep 2013 19:56:58 +0000 (21:56 +0200)
committerJiri Kosina <jkosina@suse.cz>
Fri, 13 Sep 2013 13:13:52 +0000 (15:13 +0200)
commit8821f5dc187bdf16cfb32ef5aa8c3035273fa79a
tree5cefd4e48b6eb226d8da4d887cb56dac67db64fa
parent297502abb32e225fb23801fcdb0e4f6f8e17099a
HID: multitouch: validate indexes details

When working on report indexes, always validate that they are in bounds.
Without this, a HID device could report a malicious feature report that
could trick the driver into a heap overflow:

[  634.885003] usb 1-1: New USB device found, idVendor=0596, idProduct=0500
...
[  676.469629] BUG kmalloc-192 (Tainted: G        W   ): Redzone overwritten

Note that we need to change the indexes from s8 to s16 as they can
be between -1 and 255.

CVE-2013-2897

Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-multitouch.c