From: Sachin Prabhu Date: Wed, 11 Jul 2012 11:28:05 +0000 (+0100) Subject: Initialise mid_q_entry before putting it on the pending queue X-Git-Tag: v3.5~20^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffc61ccbb96809df8d97ed609ac86b509eaf9056;p=pandora-kernel.git Initialise mid_q_entry before putting it on the pending queue A user reported a crash in cifs_demultiplex_thread() caused by an incorrectly set mid_q_entry->callback() function. It appears that the callback assignment made in cifs_call_async() was not flushed back to memory suggesting that a memory barrier was required here. Changing the code to make sure that the mid_q_entry structure was completely initialised before it was added to the pending queue fixes the problem. Signed-off-by: Sachin Prabhu Reviewed-by: Jeff Layton Reviewed-by: Shirish Pargaonkar Signed-off-by: Steve French --- Reading git-diff-tree failed