From: Patrick McHardy Date: Thu, 20 Jan 2011 03:00:42 +0000 (+0000) Subject: rtnetlink: fix link attribute validation with IFLA_GROUP X-Git-Tag: v2.6.39-rc1~468^2~488 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffa934f192c8381061242eb170419266ef229902;p=pandora-kernel.git rtnetlink: fix link attribute validation with IFLA_GROUP rtnl_group_changelink() is invoked by rtnl_newlink() before the link attributes have been validated. Additionally the group changes are performed even if NLM_F_CREATE is specified and a new link is created, while more reasonable semantics would be to set the group value on the newly created link. Fix both problems by moving the rtnl_group_changelink() invocation down to the handling of non-existant links without NLM_F_CREATE() and add a dev_set_group() call to rtnl_create_link(). Signed-off-by: Patrick McHardy Acked-by: Vlad Dogaru Signed-off-by: David S. Miller --- Reading git-diff-tree failed