From: Stephan Gerhold Date: Mon, 7 Apr 2025 09:54:21 +0000 (+0200) Subject: usb: host: ehci-msm: Fix pointer check X-Git-Tag: v2026.01-rc2~53^2~7 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fef8c84b57fd305205a13984530e81af6bf81ac3;p=pandora-u-boot.git usb: host: ehci-msm: Fix pointer check dev_read_addr_ptr() returns a null pointer on error, not FDT_ADDR_T_NONE. Fixes: 2be1130a9305 ("usb: ehci-msm: Use dev interface to get device address") Signed-off-by: Stephan Gerhold Acked-by: Caleb Connolly Tested-by: Sam Day Link: https://patch.msgid.link/20250407-ehci-msm-fixes-v1-1-f8b30eb05d07@linaro.org Signed-off-by: Casey Connolly --- diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index a759aea9db3..dd1d527a3a2 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -141,7 +141,7 @@ static int ehci_usb_of_to_plat(struct udevice *dev) priv->ulpi_vp.port_num = 0; priv->ehci = dev_read_addr_ptr(dev); - if (priv->ehci == (void *)FDT_ADDR_T_NONE) + if (!priv->ehci) return -EINVAL; /* Warning: this will not work if viewport address is > 64 bit due to