From: Jean Delvare <jdelvare@suse.de>
Date: Wed, 1 Apr 2009 18:11:29 +0000 (-0500)
Subject: [SCSI] libiscsi: fix iscsi pool error path
X-Git-Tag: v2.6.30-rc1~185^2~10
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd6e1c14b73dbab89cb76af895d5612e4a8b5522;p=pandora-kernel.git

[SCSI] libiscsi: fix iscsi pool error path

Le lundi 30 mars 2009, Chris Wright a écrit :
> q->queue could be ERR_PTR(-ENOMEM) which will break unwinding
> on error.  Make iscsi_pool_free more defensive.
>

Making the freeing of q->queue dependent on q->pool being set looks
really weird (although it is correct at the moment. But this seems
to be fixable in a much simpler way.

With the benefit that only the error case is slowed down. In both
cases we have a problem if q->queue contains an error value but it's
not -ENOMEM. Apparently this can't happen today, but it doesn't feel
right to assume this will always be true. Maybe it's the right time
to fix this as well.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---

Reading git-diff-tree failed