From: Jesper Juhl <jj@chaosbits.net>
Date: Fri, 29 Oct 2010 19:35:25 +0000 (+0200)
Subject: ALSA: asihpi - Unsafe memory management when allocating control cache
X-Git-Tag: v2.6.37-rc2~95^2~3
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd0977d0f42d3e73121b88f57c7d48ca9b861a58;p=pandora-kernel.git

ALSA: asihpi - Unsafe memory management when allocating control cache

I noticed that sound/pci/asihpi/hpicmn.c::hpi_alloc_control_cache() does
not check the return value from kmalloc(), which may fail.
If kmalloc() fails we'll dereference a null pointer and things will go bad
fast.
There are two memory allocations in that function and there's also the
problem that the first may succeed and the second may fail and nothing is
done about that either which will also go wrong down the line.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eliot Blennerhassett <linux@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

Reading git-diff-tree failed