From: Kim, Milo Date: Fri, 31 Aug 2012 09:23:03 +0000 (+0000) Subject: lp8727_charger: Cleanup _probe() and _remove() X-Git-Tag: omap-for-v3.7-rc1/fixes-cpufreq-signed~5^2~25 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb9adc5190d7605506ebc0e05351baa57365cc90;p=pandora-kernel.git lp8727_charger: Cleanup _probe() and _remove() If the lp8727_register_psy() gets failed, registered interrupt handler should be freed, but this is not complete solution. It has still problem. Assume that the IRQ occurs while unregistering power supply devices. Then the ISR will access to freed IRQ. From Anton's opinion, it can be resolved if re-ordering the call sequence. Register power supplies first, then create interrupt handler. Then no need to free the IRQ in _probe(). Additionally goto statements can be removed because those can be replaced with return statements. The _remove() should be changed the sequence - in reverse order of _probe() Signed-off-by: Milo(Woogyom) Kim Signed-off-by: Anton Vorontsov --- Reading git-diff-tree failed