From: Alexey Dobriyan Date: Sat, 24 Mar 2007 12:58:12 +0000 (+0300) Subject: [WATCHDOG] Semi-typical watchdog bug re early misc_register() X-Git-Tag: v2.6.22-rc1~105^2~7 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb8f7ba077b5c665432082ab205bcd2cb01f6a3c;p=pandora-kernel.git [WATCHDOG] Semi-typical watchdog bug re early misc_register() It seems that some watchdog drivers are doing following mistake: rv = misc_register(); if (rv < 0) return rv; rv = request_region(); if (rv < 0) { misc_deregister(); return rv; } But, right after misc_register() returns, misc device can be opened and ioctls interacting with hardware issued, and driver can do outb() to port it doesn't own yet, because request_region() is still pending. Here is my patch, compile-tested only. Signed-off-by: Alexey Dobriyan Signed-off-by: Wim Van Sebroeck --- Reading git-diff-tree failed