From: Soren Brinkmann Date: Wed, 3 Apr 2013 19:17:12 +0000 (-0700) Subject: clk: Properly handle notifier return values X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~129^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb72a0590b770f7da6a02bde6b8a147a3d9f6168;p=pandora-kernel.git clk: Properly handle notifier return values Notifiers may return NOTIFY_(OK|DONE|STOP|BAD). The CCF uses an inconsistent mix of checking against NOTIFY_STOP or NOTIFY_BAD. This inconsistency leaves errors undetected in some cases: clk_set_parent() calls __clk_speculate_rates(), which stops when it hits a NOTIFIER_BAD (STOP is ignored), and passes this value back to the caller. clk_set_parent() compares this return value against NOTIFY_STOP only, ignoring NOTIFY_BAD returns. Use NOTIFY_STOP_MASK to detect a negative notifier return value and document all four return value options. Signed-off-by: Soren Brinkmann Signed-off-by: Mike Turquette --- Reading git-diff-tree failed