From: Michael Krufky Date: Mon, 3 May 2010 05:10:15 +0000 (-0300) Subject: V4L/DVB: tda18271: fix error detection during initialization of first instance X-Git-Tag: v2.6.36-rc1~582^2~187 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fab9bfbed22f91f271a93a3dfa142179a2278935;p=pandora-kernel.git V4L/DVB: tda18271: fix error detection during initialization of first instance Fix error detection of failures during initialization of first instance: Dont pass a function into the tda_fail macro. Instead, save the function return value and pass that into the tda_fail macro. This prevents the function from being called twice in cases of failure, for example: [19026.074070] tuner 4-0060: chip found @ 0xc0 (device #0) [19026.087755] tda18271 4-0060: creating new instance [19026.089965] Unknown device detected @ 4-0060, device not supported. [19026.092233] Unknown device detected @ 4-0060, device not supported. [19026.092241] tda18271_attach: [4-0060|M] error -22 on line 1275 [19026.092327] tda18271 4-0060: destroying instance Signed-off-by: Michael Krufky Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed