From: Tony Lindgren Date: Wed, 27 Nov 2013 18:49:32 +0000 (-0800) Subject: of/platform: Fix no irq domain found errors when populating interrupts X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fa47aa69e11d2d2ee890a9ce7e5099908fda30ce;p=pandora-kernel.git of/platform: Fix no irq domain found errors when populating interrupts Currently we get the following kind of errors if we try to use interrupt phandles to irqchips that have not yet initialized: irq: no irq domain found for /ocp/pinmux@48002030 ! ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at drivers/of/platform.c:171 of_device_alloc+0x144/0x184() Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.12.0-00038-g42a9708 #1012 (show_stack+0x14/0x1c) (dump_stack+0x6c/0xa0) (warn_slowpath_common+0x64/0x84) (warn_slowpath_null+0x1c/0x24) (of_device_alloc+0x144/0x184) (of_platform_device_create_pdata+0x44/0x9c) (of_platform_bus_create+0xd0/0x170) (of_platform_bus_create+0x12c/0x170) (of_platform_populate+0x60/0x98) This is because we're wrongly trying to populate resources that are not yet available. It's perfectly valid to create irqchips dynamically, so let's fix up the issue by populating the interrupt resources at the driver probe time instead. Note that at least currently we cannot dynamically allocate the resources as bus specific code may add legacy resources with platform_device_add_resources() before the driver probe. At least omap_device_alloc() currently relies on num_resources to determine if legacy resources should be added. This issue will get fixed automatically when mach-omap2 boots with DT only, but there are probably other places too where platform_device_add_resources() modifies things before driver probe. The addition of of_platform_probe() is based on patches posted earlier by Thierry Reding . Signed-off-by: Tony Lindgren --- Reading git-diff-tree failed