From: Dan Carpenter Date: Tue, 4 Oct 2011 06:29:39 +0000 (+0300) Subject: ALSA: oss-mixer - use strlcpy() instead strcpy() X-Git-Tag: v3.2-rc1~127^2~3^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f92766bc8948f978a838a5607bea95804c8dfdfe;p=pandora-kernel.git ALSA: oss-mixer - use strlcpy() instead strcpy() This is mostly a static checker fix more than anything else. We're copying from a 64 char buffer into a 44 char buffer. The 64 character buffer is str[] in snd_mixer_oss_build_test_all(). The call tree is: snd_mixer_oss_build_test_all() -> snd_mixer_oss_build_test() -> snd_mixer_oss_build_test(). We never actually do fill str[] buffer all the way to 64 characters. The longest string is: sprintf(str, "%s Playback Switch", ptr->name); ptr->name is a 32 character buffer so 32 plus 16 characters for " Playback Switch" still puts us over the 44 limit from "id.name". Most likely ptr->name never gets filled to the limit, but we can't really change the size of that buffer so lets just use strlcpy() here and be safe. Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai --- Reading git-diff-tree failed