From: Miklos Szeredi Date: Thu, 31 Jul 2008 11:41:58 +0000 (+0200) Subject: [PATCH] move executable checking into ->permission() X-Git-Tag: v2.6.28-rc1~24^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f696a3659fc4b3a3bf4bc83d9dbec5e5a2ffd929;p=pandora-kernel.git [PATCH] move executable checking into ->permission() For execute permission on a regular files we need to check if file has any execute bits at all, regardless of capabilites. This check is normally performed by generic_permission() but was also added to the case when the filesystem defines its own ->permission() method. In the latter case the filesystem should be responsible for performing this check. Move the check from inode_permission() inside filesystems which are not calling generic_permission(). Create a helper function execute_ok() that returns true if the inode is a directory or if any execute bits are present in i_mode. Also fix up the following code: - coda control file is never executable - sysctl files are never executable - hfs_permission seems broken on MAY_EXEC, remove - hfsplus_permission is eqivalent to generic_permission(), remove Signed-off-by: Miklos Szeredi --- Reading git-diff-tree failed