From: Edward Cree Date: Tue, 16 Sep 2014 16:05:21 +0000 (+0100) Subject: sfc: fix addr_list_lock spinlock use before init X-Git-Tag: fixes-for-v3.18-merge-window~87^2~22 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f650fb456f2079b762c131a11397c0a966e2bfe4;p=pandora-kernel.git sfc: fix addr_list_lock spinlock use before init Reported by Nikolay Aleksandrov. In efx_init_port() we call efx_mac_reconfigure() to work around a Falcon/A1 limitation, and this calls efx_{arch}_filter_sync_rx_mode(), which takes the addr_list_lock; but this lock is uninitialised, because we haven't called register_netdevice() yet. So, in efx_farch_filter_sync_rx_mode(), check efx_dev_registered() before doing anything else. The EF10 equivalent, efx_ef10_filter_sync_rx_mode(), already has the corresponding check. Signed-off-by: Edward Cree Tested-by: Nikolay Aleksandrov Signed-off-by: David S. Miller --- Reading git-diff-tree failed