From: Jean Delvare Date: Thu, 5 Mar 2009 20:45:55 +0000 (-0600) Subject: [SCSI] libiscsi: fix iscsi pool error path X-Git-Tag: v2.6.30-rc1~641^2~23 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f474a37bc48667595b5653a983b635c95ed82a3b;p=pandora-kernel.git [SCSI] libiscsi: fix iscsi pool error path Memory freeing in iscsi_pool_free() looks wrong to me. Either q->pool can be NULL and this should be tested before dereferencing it, or it can't be NULL and it shouldn't be tested at all. As far as I can see, the only case where q->pool is NULL is on early error in iscsi_pool_init(). One possible way to fix the bug is thus to not call iscsi_pool_free() in this case (nothing needs to be freed anyway) and then we can get rid of the q->pool check. Signed-off-by: Jean Delvare Signed-off-by: Mike Christie Signed-off-by: James Bottomley --- Reading git-diff-tree failed