From: Matthew Wilcox <matthew@wil.cx>
Date: Tue, 12 Aug 2008 13:13:14 +0000 (-0600)
Subject: [netdrvr] atl1e: Don't take the mdio_lock in atl1e_probe
X-Git-Tag: v2.6.28-rc1~717^2~195^2~62
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd;p=pandora-kernel.git

[netdrvr] atl1e: Don't take the mdio_lock in atl1e_probe

Lockdep warns about the mdio_lock taken with interrupts enabled then later
taken from interrupt context.  Initially, I considered changing these
to spin_lock_irq/spin_unlock_irq, but then I looked at atl1e_phy_init()
and saw that it calls msleep().  Sleeping while holding a spinlock is
not allowed either.

In the probe path, we haven't registered the interrupt handler, so
it can't poke at this card yet.  It's before we call register_netdev(),
so I don't think any other threads can reach this card either.  If I'm
right, we don't need a spinlock at all.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---

Reading git-diff-tree failed