From: Tim Gardner Date: Wed, 13 Feb 2013 15:40:16 +0000 (-0700) Subject: lockd: nlmclnt_reclaim(): avoid stack overflow X-Git-Tag: v3.9-rc1~40^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f25cc71e634edcf8a15bc60a48f2b5f3ec9fbb1d;p=pandora-kernel.git lockd: nlmclnt_reclaim(): avoid stack overflow Even though nlmclnt_reclaim() is only one call into the stack frame, 928 bytes on the stack seems like a lot. Recode to dynamically allocate the request structure once from within the reclaimer task, then pass this pointer into nlmclnt_reclaim() for reuse on subsequent calls. smatch analysis: fs/lockd/clntproc.c:620 nlmclnt_reclaim() warn: 'reqst' puts 928 bytes on stack Also remove redundant assignment of 0 after memset. Cc: Trond Myklebust Signed-off-by: Tim Gardner Reviewed-by: Jeff Layton Signed-off-by: J. Bruce Fields --- Reading git-diff-tree failed