From: Ingo Molnar Date: Thu, 27 Feb 2014 11:20:31 +0000 (+0100) Subject: Revert "sched/wait: Suppress Sparse 'variable shadowing' warning" X-Git-Tag: v3.15-rc1~184^2~10 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f207dbe63c61158c234e2e8929a3725a7f6b2b9b;p=pandora-kernel.git Revert "sched/wait: Suppress Sparse 'variable shadowing' warning" This reverts commit 980f88e414418bf65569a3b62b08b07e6fc2f4c6. This warning is actually useful, don't suppress it. We actually rely on the shadowing for ___wait_cond_timeout(). We further used the __ret variable in __wait_event_timeout()'s cmd argument: __ret = schedule_timeout(__ret). That now explicitly uses the wrong __ret. Reported-by: Gregory CLEMENT Requested-by: Andrew Morton Requested-by: Peter Zijlstra Link: http://lkml.kernel.org/n/tip-Q5blhuqqzwgVwvjf1gszrdol@git.kernel.org Signed-off-by: Ingo Molnar --- Reading git-diff-tree failed