From: Julia Lawall <julia.lawall@lip6.fr>
Date: Mon, 29 Dec 2014 17:04:37 +0000 (+0100)
Subject: myri10ge: fix error return code
X-Git-Tag: fixes-v4.0-rc1~337^2~15
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f12e77caf6c21588d6b24b5f1d8a6036f9ff9378;p=pandora-kernel.git

myri10ge: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

The patch also modifies the test of mgp->cmd to satisfy checkpatch.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed