From: Joe Perches Date: Wed, 26 Aug 2015 18:13:38 +0000 (-0700) Subject: thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro X-Git-Tag: omap-for-v4.3/fixes-rc1~61^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=efd85cf86a56898686187397adfd52dfac79aff2;p=pandora-kernel.git thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses no_printk which produces no logging output but always evaluates arguments. Change the macro to surround the no_printk call with do { if (0) no_printk(...); } while (0) to avoid the unnecessary argument evaluations. $ size drivers/platform/x86/thinkpad_acpi.o* text data bss dec hex filename 60918 6184 824 67926 10956 drivers/platform/x86/thinkpad_acpi.o.new 60927 6184 824 67935 1095f drivers/platform/x86/thinkpad_acpi.o.old Signed-off-by: Joe Perches Acked-by: Henrique de Moraes Holschuh Signed-off-by: Darren Hart --- Reading git-diff-tree failed