From: Eric Dumazet Date: Thu, 17 May 2012 23:52:26 +0000 (+0000) Subject: pktgen: fix module unload for good X-Git-Tag: v3.2.18~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef6bdf34a4d247f48a9c103375fd2927d7df91e7;p=pandora-kernel.git pktgen: fix module unload for good commit d4b1133558e0d417342d5d2c49e4c35b428ff20d upstream. commit c57b5468406 (pktgen: fix crash at module unload) did a very poor job with list primitives. 1) list_splice() arguments were in the wrong order 2) list_splice(list, head) has undefined behavior if head is not initialized. 3) We should use the list_splice_init() variant to clear pktgen_threads list. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed