From: Julia Lawall <julia@diku.dk>
Date: Tue, 7 Jul 2009 02:09:50 +0000 (-0700)
Subject: drivers/net/cs89x0.c: Avoid using magic number in set_dma_mode
X-Git-Tag: v2.6.32-rc1~703^2~833
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ef0657c49e0f93dcebc9b4719e4fe0b478411f60;p=pandora-kernel.git

drivers/net/cs89x0.c: Avoid using magic number in set_dma_mode

The constant DMA_RX_MODE is defined to be 0x14 in the local include file
cs89x0.h.  Since a constant with the same name is used elsewhere with
set_dma_mode, it seems likely that this constant could be used here.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1; identifier I; constant int C; @@
(
set_dma_mode(E1,I,...)
|
*set_dma_mode(E1,C,...)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed