From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Sat, 25 Aug 2007 12:08:19 +0000 (+0200)
Subject: firewire: fw-ohci: enforce read order for selfID generation
X-Git-Tag: v2.6.24-rc1~825^2~9
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee71c2f9ee85117e41ef87357ed8f75d29369b98;p=pandora-kernel.git

firewire: fw-ohci: enforce read order for selfID generation

It seems unlikely, but access to self_id_cpu[0] could at least in theory
be deferred until after the loop over self_id_cpu[1..n] or even after
the subsequent reg_read.  Enforce the desired order by a read barrier.

Also prevent the reg_read from being reordered relative to the for loop.
This isn't necessary if the loop's conditional printk counts as an
implicit barrier, but better make it explicit.

(self_id_cpu[] is a coherent DMA buffer.)

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

Reading git-diff-tree failed