From: Dan Carpenter Date: Mon, 17 Feb 2014 19:57:31 +0000 (+0300) Subject: staging/bcm: integer underflow leads to Oom X-Git-Tag: v3.15-rc1~139^2~1004 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee2104ea865f8a12eebb382aa502f248e14a5a2d;p=pandora-kernel.git staging/bcm: integer underflow leads to Oom We do: if (NOB > DEFAULT_BUFF_SIZE) BuffSize = DEFAULT_BUFF_SIZE; else BuffSize = NOB; Since NOB can be negative it results in a larger than intended BuffSize and makes kzalloc() fail. The code is still a bit crap because it lets the users read as much as they want from nvram, but I don't know what a sensible upper limit should be. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed