From: Jesper Juhl Date: Thu, 13 Jan 2011 20:53:38 +0000 (+0100) Subject: batman-adv: Even Batman should not dereference NULL pointers X-Git-Tag: v2.6.38-rc2~33^2~28^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed7809d9c41b514115ddffaa860694393c2016b3;p=pandora-kernel.git batman-adv: Even Batman should not dereference NULL pointers There's a problem in net/batman-adv/unicast.c::frag_send_skb(). dev_alloc_skb() allocates memory and may fail, thus returning NULL. If this happens we'll pass a NULL pointer on to skb_split() which in turn hands it to skb_split_inside_header() from where it gets passed to skb_put() that lets skb_tail_pointer() play with it and that function dereferences it. And thus the bat dies. While I was at it I also moved the call to dev_alloc_skb() above the assignment to 'unicast_packet' since there's no reason to do that assignment if the memory allocation fails. Signed-off-by: Jesper Juhl Signed-off-by: Sven Eckelmann --- Reading git-diff-tree failed