From: Oleg Nesterov Date: Wed, 29 Apr 2009 14:02:24 +0000 (+0200) Subject: selinux: selinux_bprm_committed_creds() should wake up ->real_parent, not ->parent. X-Git-Tag: v2.6.31-rc1~395^2^2~37 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ecd6de3c88e8cbcad175b2eab48ba05c2014f7b6;p=pandora-kernel.git selinux: selinux_bprm_committed_creds() should wake up ->real_parent, not ->parent. We shouldn't worry about the tracer if current is ptraced, exec() must not succeed if the tracer has no rights to trace this task after cred changing. But we should notify ->real_parent which is, well, real parent. Also, we don't need _irq to take tasklist, and we don't need parent's ->siglock to wake_up_interruptible(real_parent->signal->wait_chldexit). Since we hold tasklist, real_parent->signal must be stable. Otherwise spin_lock(siglock) is not safe too and can't help anyway. Signed-off-by: Oleg Nesterov Signed-off-by: James Morris --- Reading git-diff-tree failed