From: Alexey Kuznetsov Date: Sat, 24 Mar 2007 19:52:16 +0000 (-0700) Subject: [NET]: Fix neighbour destructor handling. X-Git-Tag: v2.6.21-rc6~114^2~14 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ecbb416939da77c0d107409976499724baddce7b;p=pandora-kernel.git [NET]: Fix neighbour destructor handling. ->neigh_destructor() is killed (not used), replaced with ->neigh_cleanup(), which is called when neighbor entry goes to dead state. At this point everything is still valid: neigh->dev, neigh->parms etc. The device should guarantee that dead neighbor entries (neigh->dead != 0) do not get private part initialized, otherwise nobody will cleanup it. I think this is enough for ipoib which is the only user of this thing. Initialization private part of neighbor entries happens in ipib start_xmit routine, which is not reached when device is down. But it would be better to add explicit test for neigh->dead in any case. Signed-off-by: David S. Miller --- Reading git-diff-tree failed