From: H Hartley Sweeten Date: Thu, 25 Oct 2012 22:11:23 +0000 (-0700) Subject: staging: comedi: me_daq: cleanup me_dio_insn_bits() X-Git-Tag: omap-for-v3.8/fixes-for-merge-window-v4-signed~84^2~920 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec6521a20431723ff4fa15fdefb386184075baa2;p=pandora-kernel.git staging: comedi: me_daq: cleanup me_dio_insn_bits() This function only needs to update the output channel state when the 'mask' (data[0]) indicates that the state is changing. It's also supposed to return the state for all the input and output channels in data[1]. This function appears to work correctly but it's coded quite differently form the other comedi drivers. Rework the function so it follows the normal form. Also, use a couple local variables for the mmio addresses used to read/write the dio ports. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed