From: H Hartley Sweeten Date: Thu, 17 Apr 2014 17:07:53 +0000 (-0700) Subject: staging: comedi: amplc_dio200_common: fix the cmd->start_arg use X-Git-Tag: omap-for-v3.16/fixes-against-rc1~39^2~36^2~1333 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebe0f68eddc2e351b3b8b865f478592f231baaea;p=pandora-kernel.git staging: comedi: amplc_dio200_common: fix the cmd->start_arg use This driver supports two cmd->start_src values, TRIG_NOW and TRIG_INT. TRIG_NOW sources should always have an arg of 0. For TRIG_INT sources, the cmd->start_arg is actually the valid trig_num that is passed to the async (*inttrig) callback. This driver trivially validates the arg for both sources to be 0. Refactor the (*inttrig) so that the cmd->start_arg is used to check the trig_num instead of the open coded value. For aesthetics, refactor the (*do_cmd) to use if/else instead of the switch when handling the cmd->start_src. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed