From: Jaroslav Kysela <perex@perex.cz>
Date: Thu, 26 Jun 2008 06:51:31 +0000 (+0200)
Subject: [ALSA] Revert "alsa: add annotations to bitwise type snd_pcm_hw_param_t"
X-Git-Tag: v2.6.27-rc1~1111^2~65
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eabe3228a80728a21f871ccc86c72c170ca1a2dc;p=pandora-kernel.git

[ALSA] Revert "alsa: add annotations to bitwise type snd_pcm_hw_param_t"

This reverts commit 36b34d2437104f323e09d7c6af6451d3c0b9c0cd.

From: Al Viro <viro@ZenIV.linux.org.uk>

WIW, *all* this stuff is not bitwise at all.  For crying out loud, half
of these types are routinely used as array indices and loop variables...

If anything, we want a different set of allowed operations - subtraction
between elements of type (yielding integer), addition/subtraction of
integer types not bigger than ours (yielding our type), comparisons,
assignments (=, +=, -=, passing to function as argument, return from
function, initializers) and second/third arguments in ?:.  With 0 *not*
being allowed as a constant of such type.

It's not bitwise; we may use the same infrastructure in sparse, but it
should be a separate class of types (__attribute__((affine))).

dma_addr_t is another candidate for the same treatment, but there we'll
need helpers for conversions to hw-acceptable form (dma_to_le32(), etc.)
and gradual conversion of drivers.

ALSA ones and pm mess are absolutely straightforward cases, though.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

Reading git-diff-tree failed