From: Dan Carpenter Date: Tue, 19 Oct 2010 05:57:48 +0000 (+0200) Subject: Staging: sst: fixups in SNDRV_SST_STREAM_DECODE X-Git-Tag: v2.6.37-rc2~22^2~19 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e9f25689a86570c30d3f101b1f9834a579bed2e5;p=pandora-kernel.git Staging: sst: fixups in SNDRV_SST_STREAM_DECODE This is another patch about copying data to the kernel before using it. SNDRV_SST_STREAM_DECODE is sort of tricky because we need to do a copy_from_user() that gives us another two pointers and we have copy those. Those again give us some more pointers that we have to copy. Besides those problems, the code had a stack overflow: - struct snd_sst_buff_entry ibuf_temp[param->ibufs->entries], - obuf_temp[param->obufs->entries]; param->ibufs->entries comes from the user. Signed-off-by: Dan Carpenter Acked-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed