From: J. Bruce Fields Date: Fri, 6 Aug 2010 19:48:03 +0000 (-0400) Subject: nfsd: initialize nfsd versions before creating svc X-Git-Tag: v2.6.36-rc1~496^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e844a7b9805a2b74cfd34c8604f5bba3e0869305;p=pandora-kernel.git nfsd: initialize nfsd versions before creating svc Commit 59db4a0c102e0de226a3395dbf25ea51bf845937 "nfsd: move more into nfsd_startup()" inadvertently moved nfsd_versions after nfsd_create_svc(). On older distributions using an rpc.nfsd that does not explicitly set the list of nfsd versions, this results in svc-create_pooled() being called with an empty versions array. The resulting incomplete initialization leads to a NULL dereference in svc_process_common() the first time a client accesses the server. Move nfsd_reset_versions() back before the svc_create_pooled(); this time, put it closer to the svc_create_pooled() call, to make this mistake more difficult in the future. Signed-off-by: J. Bruce Fields --- Reading git-diff-tree failed