From: Evgeniy Polyakov Date: Sat, 25 Aug 2007 06:36:29 +0000 (-0700) Subject: [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt" X-Git-Tag: v2.6.23-rc4~3^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e7c243c925f6d9dcb898504ff24d6650b5cbb3b1;p=pandora-kernel.git [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt" I tried to preserve bridging code as it was before, but logic is quite strange - I think we should free skb on error, since it is already unshared and thus will just leak. Herbert Xu states: > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) > + goto out; If this happens it'll be a double-free on skb since we'll return NF_DROP which makes the caller free it too. We could return NF_STOLEN to prevent that but I'm not sure whether that's correct netfilter semantics. Patrick, could you please make a call on this? Patrick McHardy states: NF_STOLEN should work fine here. Signed-off-by: Evgeniy Polyakov Signed-off-by: David S. Miller --- Reading git-diff-tree failed