From: H Hartley Sweeten Date: Tue, 29 Apr 2014 19:59:56 +0000 (-0700) Subject: staging: comedi: ni_labpc: fix 8254 timer programming X-Git-Tag: omap-for-v3.16/fixes-against-rc1~39^2~36^2~1047 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e74e98993da8dff62190c937d4371eda962e64b9;p=pandora-kernel.git staging: comedi: ni_labpc: fix 8254 timer programming As pointed out by Ian Abbott, the i8254_load() function does not use the I8254_MODE* values to specify the "mode". The labpc_counter_load() function in this driver is passed an I8254_MODE* value so we need to use the i8254_set_mode() and i8254_write() helpers instead of i8254_load() to program the timers. The calls to labpc_counter_load() will not fail so change the return to void and remove all the unnecessary error handling. Similarly, change the return type of labpc_counter_set_mode() to void and remove the unnecessary error handling. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed