From: Julia Lawall Date: Wed, 11 Aug 2010 01:03:12 +0000 (-0700) Subject: drivers/char/n_gsm.c: add missing spin_unlock_irqrestore X-Git-Tag: v2.6.36-rc1~134 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e73790a57abc1320b3c3a94da43ae24359687d7c;p=pandora-kernel.git drivers/char/n_gsm.c: add missing spin_unlock_irqrestore Add a spin_unlock_irqrestore missing on the error path. Converting the return to break leads to the spin_unlock_irqrestore at the end of the function. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression E1; @@ * spin_lock_irqsave(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * spin_unlock_irqrestore(E1,...); // Signed-off-by: Julia Lawall Cc: Greg Kroah-Hartman Cc: Alan Cox Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed