From: Julia Lawall Date: Wed, 26 May 2010 05:55:10 +0000 (+0000) Subject: drivers/isdn/hardware/mISDN: Add missing spin_unlock X-Git-Tag: v2.6.35-rc2~64^2~17 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e72e9f3814cb8c1076d627c29cec90b005838ac3;p=pandora-kernel.git drivers/isdn/hardware/mISDN: Add missing spin_unlock Add a spin_unlock missing on the error path. The return value of write_reg seems to be completely ignored, so it seems that the lock should be released in every case. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression E1; @@ * spin_lock(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * spin_unlock(E1,...); // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller --- Reading git-diff-tree failed