From: Eric Dumazet Date: Thu, 12 Dec 2013 23:41:56 +0000 (-0800) Subject: pkt_sched: set root qdisc before change() in attach_default_qdiscs() X-Git-Tag: v3.14-rc1~94^2~496 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e57a784d8cae429f5b697fe55abf420181d9ff09;p=pandora-kernel.git pkt_sched: set root qdisc before change() in attach_default_qdiscs() After commit 95dc19299f74 ("pkt_sched: give visibility to mq slave qdiscs") we call disc_list_add() while the device qdisc might be the noop_qdisc one. This shows up as duplicates in "tc qdisc show", as all inactive devices point to noop_qdisc. Fix this by setting dev->qdisc to the new qdisc before calling ops->change() in attach_default_qdiscs() Add a WARN_ON_ONCE() to catch any future similar problem. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller --- Reading git-diff-tree failed