From: Ming Lei Date: Wed, 20 Mar 2013 15:25:25 +0000 (+0800) Subject: sysfs: handle failure path correctly for readdir() X-Git-Tag: v3.9-rc5~15^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5110f411d2ee35bf8d202ccca2e89c633060dca;p=pandora-kernel.git sysfs: handle failure path correctly for readdir() In case of 'if (filp->f_pos == 0 or 1)' of sysfs_readdir(), the failure from filldir() isn't handled, and the reference counter of the sysfs_dirent object pointed by filp->private_data will be released without clearing filp->private_data, so use after free bug will be triggered later. This patch returns immeadiately under the situation for fixing the bug, and it is reasonable to return from readdir() when filldir() fails. Reported-by: Dave Jones Tested-by: Sasha Levin Cc: Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed