From: Jarek Poplawski Date: Wed, 11 Aug 2010 02:02:10 +0000 (+0000) Subject: net: Fix a memmove bug in dev_gro_receive() X-Git-Tag: v2.6.36-rc2~49^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5093aec2e6b60c3df2420057ffab9ed4a6d2792;p=pandora-kernel.git net: Fix a memmove bug in dev_gro_receive() >Xin Xiaohui wrote: > I looked into the code dev_gro_receive(), found the code here: > if the frags[0] is pulled to 0, then the page will be released, > and memmove() frags left. > Is that right? I'm not sure if memmove do right or not, but > frags[0].size is never set after memove at least. what I think > a simple way is not to do anything if we found frags[0].size == 0. > The patch is as followed. ... This version of the patch fixes the bug directly in memmove. Reported-by: "Xin, Xiaohui" Signed-off-by: Jarek Poplawski Signed-off-by: David S. Miller --- Reading git-diff-tree failed