From: Dan Williams Date: Tue, 29 Nov 2011 01:11:33 +0000 (-0800) Subject: [SCSI] libsas: kill invocation of scsi_eh_finish_cmd from sas_ata_task_done X-Git-Tag: v3.4-rc1~145^2~59 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e500a34b0257def5b9ec07563afeeada1ead87bb;p=pandora-kernel.git [SCSI] libsas: kill invocation of scsi_eh_finish_cmd from sas_ata_task_done Prior to the conversion to the new-style libata-eh sas_ata_task_done() may have been the last opportunity to clean up the scmd, but now libata-eh explicitly handles this case. It also races against sas-eh. If a lldd completes a task after SAS_TASK_STATE_ABORTED is set it could trigger a spurious decrement of shost->host_failed. Current lldds have the band-aid of checking SAS_TASK_STATE_ABORTED before calling ->task_done(), but better to just let the scmds escalate to libata for race free cleanup. Signed-off-by: Dan Williams Signed-off-by: James Bottomley --- Reading git-diff-tree failed