From: dan.carpenter@oracle.com Date: Sun, 9 Jun 2013 13:07:28 +0000 (+0300) Subject: spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs() X-Git-Tag: omap-for-v3.11/fixes-for-merge-window~28^2~21^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e33d085d11e54bc9fb07b2555cd104d8e7b3089b;p=pandora-kernel.git spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs() '!' has higher precedence than comparisons so the original condition is equivalent to "if (xspi->remaining_bytes == 0)". This makes the static checkers complain. xspi->remaining_bytes is signed and from looking at the code briefly, I think it might be able to go negative. I suspect that going negative may cause a bug, but I don't have the hardware and can't test. Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- Reading git-diff-tree failed