From: Oleg Nesterov Date: Thu, 20 Jun 2013 15:50:11 +0000 (+0200) Subject: hw_breakpoint: Simplify list/idx mess in toggle_bp_slot() paths X-Git-Tag: omap-for-v3.11/fixes-for-merge-window~62^2~10 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e1ebe86203e6532eb5a0ae8f26ccae47aca548ae;p=pandora-kernel.git hw_breakpoint: Simplify list/idx mess in toggle_bp_slot() paths The enable/disable logic in toggle_bp_slot() is not symmetrical and imho very confusing. "old_count" in toggle_bp_task_slot() is actually new_count because this bp was already removed from the list. Change toggle_bp_slot() to always call list_add/list_del after toggle_bp_task_slot(). This way old_idx is task_bp_pinned() and this entry should be decremented, new_idx is +/-weight and we need to increment this element. The code/logic looks obvious. Reported-by: Vince Weaver Signed-off-by: Oleg Nesterov Acked-by: Frederic Weisbecker Link: http://lkml.kernel.org/r/20130620155011.GA6330@redhat.com Signed-off-by: Ingo Molnar --- Reading git-diff-tree failed