From: Daniel Santos Date: Sun, 5 Jan 2014 23:39:26 +0000 (-0600) Subject: spidev: fix hang when transfer_one_message fails X-Git-Tag: v3.14-rc1~91^2~7^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e120cc0dcf2880a4c5c0a6cb27b655600a1cfa1d;p=pandora-kernel.git spidev: fix hang when transfer_one_message fails This corrects a problem in spi_pump_messages() that leads to an spi message hanging forever when a call to transfer_one_message() fails. This failure occurs in my MCP2210 driver when the cs_change bit is set on the last transfer in a message, an operation which the hardware does not support. Rationale Since the transfer_one_message() returns an int, we must presume that it may fail. If transfer_one_message() should never fail, it should return void. Thus, calls to transfer_one_message() should properly manage a failure. Fixes: ffbbdd21329f3 (spi: create a message queueing infrastructure) Signed-off-by: Daniel Santos Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- Reading git-diff-tree failed