From: Zhang Rui Date: Thu, 9 Apr 2009 06:24:35 +0000 (+0800) Subject: ACPI video: handle indexed _BQC correctly X-Git-Tag: v2.6.30-rc4~50^2~5^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e047cca66c6bb0b1c346e91305011aab79dfc4b0;p=pandora-kernel.git ACPI video: handle indexed _BQC correctly In the current code, for a box with an indexed _BQC method, we 1. get the current brightness level by evaluating _BQC 2. set the value gotten in step 1 to _BCM 3. get the current brightness level again 4. set the _BQC_use_index flag if the results gotten in step 1 and in step 3 don't equal. But this logic doesn't work actually, because the _BQC_use_index is not set when acpi_video_device_lcd_set_level is invoked. This results in a failure in step 2. http://bugzilla.kernel.org/show_bug.cgi?id=12249#c83 Now, we set the _BQC_use_index flag after invoking _BQC for the first time. And reevaluate the _BQC to get the correct brightness level. Signed-off-by: Zhang Rui Signed-off-by: Len Brown --- Reading git-diff-tree failed